Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config-win32: set HAVE_SNPRINTF for mingw-w64 #12325

wants to merge 1 commit into from


Copy link

@vszakats vszakats commented Nov 15, 2023

It's available in all mingw-w64 releases. We already pre-fill this
detection in CMake.

Closes #12325

@vszakats vszakats added the build label Nov 15, 2023
@github-actions github-actions bot added the Windows Windows-specific label Nov 15, 2023
vszakats added a commit to curl/curl-for-win that referenced this pull request Nov 15, 2023
- enable symbol hiding manually to match cmake/autotools.

- enable variadic macros. These macros became required in curl 8.3.0
  with curl/curl#11421.
  These macros will no longer be needed with curl 8.5.0
  after curl/curl#12167.

- set `HAVE_SNPRINTF`. curl's `config-win32.h` missed to set it,
  causing a minor difference in the generated binaries compared to
  cmake/autotools builds.
  Ref: curl/curl#12325

With these changes GNU Make builds are in sync again with
@vszakats vszakats closed this in 6608f34 Nov 15, 2023
@vszakats vszakats deleted the win-snprintf-mingw branch November 15, 2023 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
build Windows Windows-specific

Successfully merging this pull request may close these issues.

None yet

1 participant