Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Don't retry requests with CURLOPT_NOBODY except for HTTP retries #1243
This reverts commit 31e33a9.
Using sftp to delete a file with CURLOPT_NOBODY set with a reused connection would fail as curl expected to get some data. Thus it would retry the command again which fails as the file has already been deleted.
This issue had originally been fixed in 12f5c67 which I found out about from https://curl.haxx.se/mail/lib-2006-02/0029.html. However the fix got removed in 31e33a9. A straight revert as this PR does currently is perhaps not sufficient as there should at least be a comment explaining the reason for the