multi: during ratelimit multi_getsock should return no sockets#12430
Closed
bagder wants to merge 1 commit into
Closed
multi: during ratelimit multi_getsock should return no sockets#12430bagder wants to merge 1 commit into
bagder wants to merge 1 commit into
Conversation
... as there is nothing to wait for then, it just waits. Otherwise, this causes much more CPU work and updates than newessary during ratelimit periods.
icing
approved these changes
Nov 30, 2023
icing
left a comment
icing
left a comment
Contributor
There was a problem hiding this comment.
Running curl --silent --limit-rate 1000 https://curl.se/?[0-4] -o /dev/null -w '%{speed_download}\n' gives:
908
921
921
908
1103
adding -Z gives:
1088
1052
1024
1024
915
I'd say it looks good!
Member
Author
|
My test command is this ... which after about 10 seconds stabilizes on 5120-5125k per second. (5*1024 == 5120) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as there is nothing to wait for then, it just waits. Otherwise, this causes much more CPU work and updates than necessary during ratelimit periods.
Ref: https://curl.se/mail/lib-2023-11/0056.html