Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix generation for system name iOS #12515

wants to merge 3 commits into from


Copy link

@marksinkovics marksinkovics commented Dec 14, 2023

This PR fixes a problem that happens during CMake configuration when the CMAKE_SYSTEM_NAME set to iOS and not Darwin. This value is available (as far as I remember) version 3.14. The final solution (thanks to @vszakats) is to use APPLE which contains all the Apple platforms

This issue was found when during vcpkg installation. Running command vcpkg install curl:arm64-ios and vcpkg install curl:x64-ios failed with message

CMake Error: try_run() invoked in cross-compiling mode, please set the following cache variables appropriately:

After this fix, I was able to compile the compile the binary without any issue.

In addition to that fix, this PR also contains an simplification to check if the platform is not APPLE.

Thank you very much for reviewing!

CMake/OtherTests.cmake Outdated Show resolved Hide resolved
@vszakats vszakats changed the title fix: CMake generation for system name iOS cmake: fix generation for system name iOS Dec 14, 2023
@vszakats vszakats added the appleOS specific to an Apple operating system label Dec 14, 2023
@vszakats vszakats closed this in a86254b Dec 16, 2023
Copy link

Thank you, merged now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
appleOS specific to an Apple operating system build cmake

Successfully merging this pull request may close these issues.

None yet

3 participants