configure: Allow disabling pthreads, fall back on Win32 threads #1260

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@jay
Member
jay commented Feb 12, 2017

When the threaded resolver is used pthreads is the default, however this
change makes it possible to --disable-pthreads and then configure can
fall back on Win32 threads for native Windows builds.

Closes #xxxx


Context from ./configure --help output:

  --enable-threaded-resolver
                          Enable threaded resolver
  --disable-threaded-resolver
                          Disable threaded resolver
  --enable-pthreads       Enable POSIX threads (default for threaded resolver)
  --disable-pthreads      Disable POSIX threads

Context from curl_config.h when mingw ./configure --disable-pthreads --enable-threaded-resolver:

/* if you want POSIX threaded DNS lookup */
/* #undef USE_THREADS_POSIX */

/* if you want Win32 threaded DNS lookup */
#define USE_THREADS_WIN32 1
@jay jay configure: Allow disabling pthreads, fall back on Win32 threads
When the threaded resolver is used pthreads is the default, however this
change makes it possible to --disable-pthreads and then configure can
fall back on Win32 threads for native Windows builds.

Closes #xxxx
c9fe4d1
@mention-bot

@jay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @yangtse and @dfandrich to be potential reviewers.

@jay jay added the build label Feb 12, 2017
@bagder
bagder approved these changes Feb 13, 2017 View changes

Looks fine to me!

@jay jay added a commit that closed this pull request Feb 14, 2017
@jay jay configure: Allow disabling pthreads, fall back on Win32 threads
When the threaded resolver option is specified for configure the default
thread library is pthreads. This change makes it possible to
--disable-pthreads and then configure can fall back on Win32 threads for
native Windows builds.

Closes #1260
c107128
@jay jay closed this in c107128 Feb 14, 2017
@jay jay deleted the jay:configure_add_pthreads_option branch Feb 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment