Add note on auto-detection of MACHINE in Makefile.vc #1265

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@webmaster128
Contributor

No description provided.

@webmaster128 webmaster128 Add note on auto-detection of MACHINE in Makefile.vc
fb84a1c
@mention-bot

@webmaster128, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vszakats, @Jan-E and @BurningEnlightenment to be potential reviewers.

@rodwiddowson

ugh!. Nice find and important comment. Thanks for this,

@webmaster128
Contributor

Thanks for the positive feedback, my pleasure!

What I found especially confusing while debugging this was that PROCESSOR_ARCHITECTURE is still "AMD64" in the 32 bit build environment but then changed to "x86" when running nmake.

@bagder bagder closed this in 3cc30e8 Feb 16, 2017
@bagder
Member
bagder commented Feb 16, 2017

Thanks!

@webmaster128 webmaster128 deleted the webmaster128:architecture-help branch Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment