Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note on auto-detection of MACHINE in Makefile.vc #1265

Closed
wants to merge 1 commit into from

Conversation

@webmaster128
Copy link
Contributor

@webmaster128 webmaster128 commented Feb 16, 2017

No description provided.

@mention-bot
Copy link

@mention-bot mention-bot commented Feb 16, 2017

@webmaster128, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vszakats, @Jan-E and @BurningEnlightenment to be potential reviewers.

@rodwiddowson
Copy link
Contributor

@rodwiddowson rodwiddowson commented Feb 16, 2017

ugh!. Nice find and important comment. Thanks for this,

@webmaster128
Copy link
Contributor Author

@webmaster128 webmaster128 commented Feb 16, 2017

Thanks for the positive feedback, my pleasure!

What I found especially confusing while debugging this was that PROCESSOR_ARCHITECTURE is still "AMD64" in the 32 bit build environment but then changed to "x86" when running nmake.

@bagder bagder closed this in 3cc30e8 Feb 16, 2017
@bagder
Copy link
Member

@bagder bagder commented Feb 16, 2017

Thanks!

@webmaster128 webmaster128 deleted the webmaster128:architecture-help branch Feb 24, 2017
@lock lock bot locked as resolved and limited conversation to collaborators May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.