Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telnet: use dynbuf instad of malloc for escape buffer #12652

Closed
wants to merge 1 commit into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jan 7, 2024

Previously, send_telnet_data() would malloc + free a buffer every time for escaping IAC codes. Now, it reuses a dynbuf for this purpose.

@bagder bagder added the tidy-up label Jan 7, 2024
@jay
Copy link
Member

jay commented Jan 7, 2024

LGTM. Note a bunch of jobs are failing MQTT testing, not sure why that is.

Previously, send_telnet_data() would malloc + free a buffer every time
for escaping IAC codes. Now, it reuses a dynbuf for this purpose.

Closes #12652
@bagder bagder closed this in 2959f45 Jan 9, 2024
@bagder bagder deleted the bagder/telnet-dynbuf branch January 9, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants