Skip to content

configure: make libpsl detection failure cause an error #12661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

bagder
Copy link
Member

@bagder bagder commented Jan 8, 2024

To force users to explictily disable it if they really don't want it used and make it harder to accidentally miss it.

@bagder bagder changed the title configure: make libpsl detection failue cause an error configure: make libpsl detection failure cause an error Jan 8, 2024
@bagder bagder force-pushed the bagder/configure-libpsl branch from c8610c0 to c76ac1a Compare January 8, 2024 15:49
@github-actions github-actions bot added the CI Continuous Integration label Jan 8, 2024
@bagder bagder force-pushed the bagder/configure-libpsl branch from c76ac1a to 7790425 Compare January 8, 2024 16:16
@bagder bagder closed this in 2998874 Jan 9, 2024
@bagder bagder deleted the bagder/configure-libpsl branch January 9, 2024 08:11
KexyBiscuit added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Jan 31, 2024
KexyBiscuit added a commit to AOSC-Dev/aosc-os-abbs that referenced this pull request Jan 31, 2024
@xylar xylar mentioned this pull request Mar 15, 2024
4 tasks
vszakats added a commit to vszakats/curl that referenced this pull request Aug 15, 2024
vszakats added a commit that referenced this pull request Aug 15, 2024
Also:
- explicitly disable libpsl in CI to avoid configure warning, where
  necessary.
- add TODO to make this warning an error (to match autotools.)

Follow-up to 2998874 #12661

Closes #14533
vszakats added a commit to vszakats/curl that referenced this pull request Oct 31, 2024
As in `./configure`:

To force users to explictily disable it if they really don't want it
used and make it harder to accidentally miss it.

`-DCURL_USE_LIBPSL=OFF` is the option to use if PSL is not wanted.

Follow-up to 2998874 curl#12661
vszakats added a commit that referenced this pull request Dec 16, 2024
As done earlier in `./configure`:

To force users to explictily disable it if they really don't want it
used and make it harder to accidentally miss it.

`-DCURL_USE_LIBPSL=OFF` is the option to use if PSL is not wanted.

Follow-up to 2998874 #12661

Closes #15464
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build CI Continuous Integration cookies
Development

Successfully merging this pull request may close these issues.

1 participant