multi: fix odd total timer reset in file_do() while fetching file:// #12682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The total timer is properly reset in MSTATE_INIT. MSTATE_CONNECT starts with resetting the timer that is a start point for further multi states. If file://, MSTATE_DO calls file_do() that should not reset the total timer. Otherwise, the total time is always less than the pre-transfer and the start transfer times.
sergio-nsk
force-pushed
the
sergio-nsk/timings/1
branch
from
41c03fc
to
7478cc1
Compare
sergio-nsk
changed the title
bagder
approved these changes
Jan 11, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working with timings with file:// urls, I've notices an issue: the total time interval is always less than the pre-transfer and the start transfer time intervals. The reason:
Curl_prgsStartNow()is called twice: inMSTATE_INIT(properly) and inMSTATE_DOinfile_do(), andTIMER_STARTSINGLEis set between those calls inMSTATE_CONNECT.