Fixes SFTP upload with --create-dirs when running via multi handle #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jgressmann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @yangtse and @greearb to be potential reviewers. |
Multiple parallel SFTP uploads via a multi handle will fail unless these rc's are cleared.
|
Thanks, I squashed them and merged just now! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
So this is odd.
will work fine and create the necessary dirs.
If I do the equivalent but run it with a multi handle the socket will be retired due to the rc not being reset in line 1803.
Similarly, the rc needs to be reset to 0 if some part of the directory hierarchy exists (lines 1955-1957).
Finally, line 1939 takes all error codes into account.
Cheers,
Jean