New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes SFTP upload with --create-dirs when running via multi handle #1269

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@jgressmann
Contributor

jgressmann commented Feb 19, 2017

So this is odd.

curl -k sftp://foo:bar@localhost/~/1/2/3/4/5/6/7/8  --ftp-create-dirs -T file  -vvvv

will work fine and create the necessary dirs.

If I do the equivalent but run it with a multi handle the socket will be retired due to the rc not being reset in line 1803.
Similarly, the rc needs to be reset to 0 if some part of the directory hierarchy exists (lines 1955-1957).
Finally, line 1939 takes all error codes into account.

Cheers,
Jean

@mention-bot

This comment has been minimized.

mention-bot commented Feb 19, 2017

@jgressmann, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @yangtse and @greearb to be potential reviewers.

ssh: more clearing of rc in case things fail
Multiple parallel SFTP uploads via a multi handle will fail unless these
rc's are cleared.

@bagder bagder added the SCP/SFTP label Feb 20, 2017

@bagder bagder closed this in af30f11 Feb 20, 2017

@bagder

This comment has been minimized.

Member

bagder commented Feb 20, 2017

Thanks, I squashed them and merged just now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment