websockets, check for negative payload lengths#12707
Closed
icing wants to merge 6 commits intocurl:masterfrom
Closed
websockets, check for negative payload lengths#12707icing wants to merge 6 commits intocurl:masterfrom
icing wants to merge 6 commits intocurl:masterfrom
Conversation
Contributor
icing
commented
Jan 15, 2024
icing
commented
- in en- and decoding, check the websocket frame payload lengths for negative values (from curl_off_t) and error the operation in that case
piru
reviewed
Jan 15, 2024
bagder
approved these changes
Jan 15, 2024
Member
|
Except that ASAN complains on the new test:
|
- in en- and decoding, check the websocket frame payload lengths for negative values (from curl_off_t) and error the operation in that case
Member
|
lgtm but hyper ci is failing: |
Member
it is really complicated sometimes to get the same error codes for hyper but 52 ( |
Contributor
Author
I declare test 2307 does not work with hyper at all. Nowhere do I see the server response data being processed. Change my mind. |
bagder
reviewed
Jan 16, 2024
Member
|
@icing: this new test 2307 seems to be flaky and has already failed for me locally and in CI builds after this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.