-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
websockets, check for negative payload lengths #12707
Conversation
icing
commented
Jan 15, 2024
- in en- and decoding, check the websocket frame payload lengths for negative values (from curl_off_t) and error the operation in that case
Except that ASAN complains on the new test:
|
- in en- and decoding, check the websocket frame payload lengths for negative values (from curl_off_t) and error the operation in that case
lgtm but hyper ci is failing:
|
it is really complicated sometimes to get the same error codes for hyper but 52 ( |
I declare test 2307 does not work with hyper at all. Nowhere do I see the server response data being processed. Change my mind. |
@icing: this new test 2307 seems to be flaky and has already failed for me locally and in CI builds after this... |