Skip to content

tool_operate: stop setting the comment on Amiga#12709

Closed
bagder wants to merge 1 commit intomasterfrom
bagder/rm-amiga-set-comment
Closed

tool_operate: stop setting the comment on Amiga#12709
bagder wants to merge 1 commit intomasterfrom
bagder/rm-amiga-set-comment

Conversation

@bagder
Copy link
Copy Markdown
Member

@bagder bagder commented Jan 15, 2024

  • the URL is capped at 80 cols, which ruins it if longer
  • it does not strip off URL credentials
  • it is done unconditonally, not on --xattr
  • we don't have Amiga in the CI which makes fixing it blindly fragile

Someone who builds and tests on Amiga can add it back correctly in a future if there is a desire.

Reported-by: Harry Sintonen

- the URL is capped at 80 cols, which ruins it if longer
- it does not strip off URL credentials
- it is done unconditonally, not on --xattr
- we don't have Amiga in the CI which makes fixing it blindly fragile

Someone who builds and tests on Amiga can add it back correctly in a
future if there is a desire.

Reported-by: Harry Sintonen
@bagder bagder closed this in ba01cac Jan 15, 2024
@bagder bagder deleted the bagder/rm-amiga-set-comment branch January 15, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

1 participant