Closed
Conversation
Member
|
Can you also add a description to HTTP3.md how to build this setup? |
- HTTP/3 for curl using OpenSSL's own QUIC stack together
with nghttp3
- configure with `--with-openssl-quic` to enable curl to
build this. This requires the nghttp3 library
- implementation with the following restrictions:
* macOS has to use an unconnected UDP socket due to an
issue in OpenSSL's datagram implementation
See openssl/openssl#23251
This makes connections to non-reponsive servers hang.
* GET requests will send the indicator that they have
no body in a separate QUIC packet. This may result
in processing delays or Transfer-Encodings on proxied
requests
* uploads that encounter blocks will use 100% cpu as
detection of these flow control issue is not working
(we have not figured out to pry that from OpenSSL).
- remove no longer neede config param in building openssl3
Contributor
Author
Done. |
icing
added
feature-window
icing
changed the title
bagder
reviewed
Jan 22, 2024
Member
bagder
left a comment
bagder
left a comment
There was a problem hiding this comment.
Otherwise I think this looks good!
vszakats
added a commit
to curl/curl-for-win
that referenced
this pull request
Jan 22, 2024
It works with some manual hacks due to nghttp3 being undetected by autotools (a long-time issue). When enabled, the version string is showing some duplication: ``` curl 8.6.0-DEV (x86_64-w64-mingw32) libcurl/8.6.0-DEV OpenSSL/3.2.0 (Schannel) zlib/1.3 WinIDN libssh2/1.11.1_DEV nghttp2/1.58.0 OpenSSL/3.2.0 (Schannel) nghttp3/1.1.0 Release-Date: [unreleased] Protocols: dict file ftp ftps gopher gophers http https imap imaps ipfs ipns ldap ldaps mqtt pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp ws wss Features: alt-svc AsynchDNS HSTS HTTP2 HTTP3 HTTPS-proxy IDN IPv6 Kerberos Largefile libz MultiSSL NTLM SPNEGO SSL SSPI threadsafe UnixSockets ``` Ref: curl/curl@0535f6e Ref: curl/curl#12734
Member
|
Few observations after enabling support for this in curl-for-win:
|
Contributor
|
@icing Can you add the cmake functionality / flag to compile http3 with openssl 3.2 + nghttp3 ? |
Contributor
Author
|
@talregev I must admit my cmake skills are lacking. |
Contributor
|
I will open an issue about it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--with-openssl-quicto enable curl to build this. This requires the nghttp3 library