Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: de-duplicate HTMLPAGES and PDFPAGES variables #1287

Closed
wants to merge 1 commit into from

Conversation

@Lekensteyn
Copy link
Member

commented Feb 25, 2017

Make use of macro substitution of suffix patterns to reduce duplication
of manual names. This approach is portable according to
http://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html

I also verified that the HTMLPAGES and PDFPAGES variables contain the exact same result (but with different extension).

Beautiful diffstat :-)

 docs/libcurl/Makefile.am      |  44 +--
 docs/libcurl/opts/Makefile.am | 622 +-----------------------------------------
 2 files changed, 5 insertions(+), 661 deletions(-)
Make use of macro substitution of suffix patterns to reduce duplication
of manual names. This approach is portable according to
http://pubs.opengroup.org/onlinepubs/009695399/utilities/make.html
@mention-bot

This comment has been minimized.

Copy link

commented Feb 25, 2017

@Lekensteyn, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @jay and @frenche to be potential reviewers.

@Lekensteyn Lekensteyn added the build label Feb 25, 2017
@jay jay closed this in eac0dc6 Feb 25, 2017
@jay

This comment has been minimized.

Copy link
Member

commented Feb 25, 2017

Thanks

@lock lock bot locked as resolved and limited conversation to collaborators May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.