test 1165: improve pattern matching

[Karlson2k]

• Fix possible part of the symbol match.
• Fix excluded digits at the end of the symbols (CURL_DISABLE_POP3 was checked as CURL_DISABLE_POP)

Discovered while working on PR #12897

[Karlson2k]

Two failed checks seems to be unrelated.

[bagder]

This cannot be correct, since it puts the wrong part into $1.

Why not just extend the pattern? Surely it doesn't do any false positive matches elsewhere?

 if(/(CURL_DISABLE_[A-Z0-9_]+)/g) {

[Karlson2k]

Nope. :)
It is non-capturing group because of ?:
(?:^|[^A-Za-z0-9\-]) is matched but not captured.
The same for (?:$|[^A-Za-z0-9\-]).

It works correctly, I tested it with modified script version with printing all matched results.
Right now there are no false positives here even without the start and end patterns. But this is the test, it must catch incorrect code changes.

[bagder]

Ok thanks, that goes beyond what I knew. I still think it's overly complicated for no good reason.

[bagder]

Same here

[Karlson2k]

It works as well.
I don't create PRs without proper local testing.
I added debug printing of the results and results are fine.

[bagder]

and here

[Karlson2k]

This one is correct too.

[Karlson2k]

@bagder The code works correctly.
You don't have questions about documentation pattern matching. It must get all values from documentation. As tests are passed everywhere, it means that matching symbols were found in autoconf, cmake and sources. Otherwise tests would fail.
These non-capturing groups are actually a poor-man replacement for \b (word boundary) which was added in Perl 5.22 As a bonus - it does not depend on used locale.

Let me know, please, if you still think that code should be simplified by removing non-capturing groups.

[Karlson2k]

Force-pushed with correct commit text (and rebased)

[bagder]

Let me know, please, if you still think that code should be simplified by removing non-capturing groups.

I think so. The regexes should be as simple as possible to help readers understand then.

[Karlson2k]

Updated with non-capturing groups removed, as requested.

[Karlson2k]

Two build failures seem to be unrelated.

[bagder]

Thanks!