New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix --with-zlib when a path is specified #1292

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@greg-rowe

greg-rowe commented Feb 26, 2017

Prior to this change if you attempted to configure curl using
--wtih-zlib and specified a path the path would be ignored if you also
had pkg-config installed on your system. This situation can easily
arise when you are cross compiling. This change moves the test for
detecting zlib settings via pkg-config only if OPT_ZLIB is not set.

Greg Rowe
build: fix --with-zlib when a path is specified
Prior to this change if you attempted to configure curl using
--wtih-zlib and specified a path the path would be ignored if you also
had pkg-config installed on your system.  This situation can easily
arise when you are cross compiling.  This change moves the test for
detecting zlib settings via pkg-config only if OPT_ZLIB is not set.
@mention-bot

This comment has been minimized.

mention-bot commented Feb 26, 2017

@greg-rowe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ghedo, @gknauf and @bagder to be potential reviewers.

@bagder bagder added the build label Feb 28, 2017

@jay jay closed this in 6fc91f6 Mar 3, 2017

@jay

This comment has been minimized.

Member

jay commented Mar 3, 2017

Thanks

@lock lock bot locked as resolved and limited conversation to collaborators May 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.