build: fix --with-zlib when a path is specified #1292

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@greg-rowe

Prior to this change if you attempted to configure curl using
--wtih-zlib and specified a path the path would be ignored if you also
had pkg-config installed on your system. This situation can easily
arise when you are cross compiling. This change moves the test for
detecting zlib settings via pkg-config only if OPT_ZLIB is not set.

Greg Rowe build: fix --with-zlib when a path is specified
Prior to this change if you attempted to configure curl using
--wtih-zlib and specified a path the path would be ignored if you also
had pkg-config installed on your system.  This situation can easily
arise when you are cross compiling.  This change moves the test for
detecting zlib settings via pkg-config only if OPT_ZLIB is not set.
60fb6f0

@greg-rowe, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ghedo, @gknauf and @bagder to be potential reviewers.

@bagder bagder added the build label Feb 28, 2017
@jay jay added a commit that closed this pull request Mar 3, 2017
@jay Greg Rowe + jay configure: fix --with-zlib when a path is specified
Prior to this change if you attempted to configure curl using
--wtih-zlib and specified a path the path would be ignored if you also
had pkg-config installed on your system.  This situation can easily
arise when you are cross compiling.  This change moves the test for
detecting zlib settings via pkg-config only if OPT_ZLIB is not set.

Closes #1292
6fc91f6
@jay jay closed this in 6fc91f6 Mar 3, 2017
Owner
jay commented Mar 3, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment