Repository navigation
Conversation
Member
|
I notice all other file reads in checksrc are handled with diff --git a/scripts/checksrc.pl b/scripts/checksrc.pl
index 76f4660..be085e0 100755
--- a/scripts/checksrc.pl
+++ b/scripts/checksrc.pl
@@ -120,6 +120,7 @@ sub readlocalfile {
open(my $rcfile, "<", "$dir/.checksrc") or return;
while(<$rcfile>) {
+ $windows_os ? $_ =~ s/\r?\n$// : chomp;
$i++;
# Lines starting with '#' are considered comments |
Contributor
Author
|
We can use both fixes. |
Karlson2k
force-pushed
the
gitattributes_fix_01
branch
from
February 18, 2024 06:37
97619fd to
d4d4ece
Compare
Member
|
Thanks. I landed this but omitted the gitattributes change. IMO there's no reason to have a special exception since it can now be handled like the other input files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes debug builds on Windows.
CRLF line ending in
.checksrcfiles is not handled byscripts/checksrc.pl