Skip to content

openssl-quic: fix BIO leak and Windows warning - #13043

Closed
vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:osslq-fix1
Closed

vszakats wants to merge 1 commit into
curl:masterfrom
vszakats:osslq-fix1

Conversation

@vszakats

@vszakats vszakats commented Mar 4, 2024 •

Copy link
Copy Markdown
Member

Caused by an accidentally duplicated line in
d6825df.

.../lib/vquic/curl_osslq.c:1095:30: warning: implicit conversion loses integer precision: 'curl_socket_t' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
 1095 |   bio = BIO_new_dgram(ctx->q.sockfd, BIO_NOCLOSE);
      |         ~~~~~~~~~~~~~ ~~~~~~~^~~~~~
1 warning and 2 errors generated.

Closes #13043

Caused by an accidentally duplicated line in
d6825df.

```
.../lib/vquic/curl_osslq.c:1095:30: warning: implicit conversion loses integer precision: 'curl_socket_t' (aka 'unsigned long long') to 'int' [-Wshorten-64-to-32]
 1095 |   bio = BIO_new_dgram(ctx->q.sockfd, BIO_NOCLOSE);
      |         ~~~~~~~~~~~~~ ~~~~~~~^~~~~~
1 warning and 2 errors generated.
```

Closes #xxxxx
@vszakats vszakats added the HTTP/3 h3 or quic related label Mar 4, 2024
@vszakats vszakats changed the title openssl-quic: fix bio leak and Windows warning openssl-quic: fix BIO leak and Windows warning Mar 5, 2024
@vszakats vszakats closed this in 9c7768c Mar 5, 2024
@vszakats
vszakats deleted the osslq-fix1 branch March 5, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HTTP/3 h3 or quic related

Development

Successfully merging this pull request may close these issues.

2 participants