Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

done with "bool *done" param #13096

wants to merge 2 commits into from

done with "bool *done" param #13096

wants to merge 2 commits into from


Copy link

@icing icing commented Mar 11, 2024

A transfer may do several SingleRequests for its success. This happens regularly for authentication, follows and retries on failed connections. The "readwrite()" calls and functions connected to those carried a bool *done parameter to indicate that the current SingleRequest is over. This may happen before upload_done or download_done bits of SingleRequest are set.

The problem with that is now write_resp() protocol handlers are invoked in places where the bool *done cannot be passed up to the caller. Instead of being a bool in the call chain, it needs to become a member of SingleRequest, reflecting its state.

This PR removes the bool *done parameter and adds the done bit to SingleRequest instead. It adds Curl_req_soft_reset() for using a SingleRequest in a follow up, clearing done and other flags/counters.

- use in h1 proxy for continuation after successful CONNECT
@bagder bagder closed this in 4e4e8af Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants