Repository navigation
Conversation
- use in h1 proxy for continuation after successful CONNECT
bagder
approved these changes
Mar 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A transfer may do several
SingleRequests for its success. This happens regularly for authentication, follows and retries on failed connections. The "readwrite()" calls and functions connected to those carried abool *doneparameter to indicate that the currentSingleRequestis over. This may happen beforeupload_doneordownload_donebits ofSingleRequestare set.The problem with that is now
write_resp()protocol handlers are invoked in places where thebool *donecannot be passed up to the caller. Instead of being a bool in the call chain, it needs to become a member ofSingleRequest, reflecting its state.This PR removes the
bool *doneparameter and adds thedonebit toSingleRequestinstead. It addsCurl_req_soft_reset()for using aSingleRequestin a follow up, clearingdoneand other flags/counters.