spnego_gssapi: implement TLS channel bindings for openssl #13098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foorack
force-pushed
the
openssl-spnego-channel-binding
branch
from
a0d34ca
to
7acadc0
Compare
|
"Linux / hyper" CI failed during |
DemiMarie
reviewed
Mar 12, 2024
Foorack
force-pushed
the
openssl-spnego-channel-binding
branch
from
7acadc0
to
5b8c0eb
Compare
|
Rebased to bring PR up-to-date with master due to time passed. Minor changes
|
Foorack
force-pushed
the
openssl-spnego-channel-binding
branch
2 times, most recently
from
d916f49
to
d776382
Compare
DemiMarie
reviewed
Apr 24, 2024
Foorack
force-pushed
the
openssl-spnego-channel-binding
branch
from
a1a6fad
to
3d924fa
Compare
Foorack
force-pushed
the
openssl-spnego-channel-binding
branch
from
dff77a8
to
c464df2
Compare
|
Reverted Explicit Fetching implementation, for now, in order to be in-line with the rest of CURL source code. Potential migration from Implicit to Explicit Fetching is outside the scope of this specific PR. Also resolved merge conflicts to keep branch up-to-date. |
|
@bagder We've been running this change in Production on hundreds of clients for several months, and it's been working great. What is the next step for this to be merged? |
bagder
reviewed
Jun 18, 2024
Foorack
force-pushed
the
openssl-spnego-channel-binding
branch
2 times, most recently
from
d5a4b56
to
3c771e4
Compare
Channel Bindings are used to tie the session context to a specific TLS channel. This is to provide additional proof of valid identity, mitigating authentication relay attacks. Major web servers have the ability to require (None/Accept/Require) GSSAPI channel binding, rendering Curl unable to connect to such websites unless support for channel bindings is implemented. IIS calls this feature Extended Protection (EPA), which is used in Enterprise environments using Kerberos for authentication. This change require krb5 >= 1.19, otherwise channel bindings won't be forwarded through SPNEGO. Co-Authored-By: Steffen Kieß <947515+steffen-kiess@users.noreply.github.com>
This reverts commit 3d924fa.
Foorack
force-pushed
the
openssl-spnego-channel-binding
branch
from
3c771e4
to
be3512c
Compare
|
Some tests failed because Launchpad was temporarily down. |
|
All tests pass now! |
MarcelRaad
approved these changes
Aug 7, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channel Bindings are used to tie the session context to a specific TLS channel. This is to provide additional proof of valid identity, mitigating authentication relay attacks.
Major web servers have the ability to require (None/Accept/Require) GSSAPI channel binding, rendering Curl unable to connect to such websites unless support for channel bindings is implemented.
IIS calls this feature Extended Protection (EPA), which is used in Enterprise environments using Kerberos for authentication.
This change require krb5 >= 1.19, otherwise channel bindings won't be forwarded through SPNEGO.