Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mbedtls: support CURLOPT_CERTINFO #13113

Closed
wants to merge 2 commits into from

Conversation

sergio-nsk
Copy link
Contributor

No description provided.

@bagder
Copy link
Member

bagder commented Mar 18, 2024

The Linux / mbedtls job fails here. Was that just a temporary glitch or is this PR making it fail?

@sergio-nsk sergio-nsk force-pushed the mbedtls_certinfo branch 2 times, most recently from 8ae324c to 28ac622 Compare March 18, 2024 17:01
@sergio-nsk
Copy link
Contributor Author

The Linux / mbedtls job fails here. Was that just a temporary glitch or is this PR making it fail?

I don't know, it looked so. The first commit could not interrupt mbed_connect_step2() because the result of collect_server_cert() was ignored, hence it could not fail the tests.

tests/http/test_10_proxy.py::TestProxy::test_10_02_proxys_down[0-http/1.1] FAILED [ 63%]
tests/http/test_10_proxy.py::TestProxy::test_10_02_proxys_down[0-h2] FAILED [ 63%]
tests/http/test_10_proxy.py::TestProxy::test_10_14_proxys_ip_addr[0-http/1.1] FAILED [ 82%]
tests/http/test_10_proxy.py::TestProxy::test_10_14_proxys_ip_addr[0-h2] FAILED [ 82%]

@sergio-nsk sergio-nsk closed this Mar 18, 2024
@sergio-nsk sergio-nsk reopened this Mar 18, 2024
@sergio-nsk sergio-nsk force-pushed the mbedtls_certinfo branch 2 times, most recently from 50a9f79 to 04a2428 Compare March 18, 2024 21:48
@sergio-nsk sergio-nsk marked this pull request as draft March 18, 2024 22:31
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume the fact that this PR is still in draft is not significant?

@sergio-nsk
Copy link
Contributor Author

I am experimenting with what is wrong with the proxy tests on Linux/mbedtls. I've disabled SSLSUPP_CERTINFO and got the tests passed. All looks well in other tests, I might miss something in other files.

@sergio-nsk sergio-nsk force-pushed the mbedtls_certinfo branch 2 times, most recently from 21178e9 to 21bde06 Compare April 21, 2024 22:30
@github-actions github-actions bot added the CI Continuous Integration label Apr 21, 2024
@sergio-nsk sergio-nsk force-pushed the mbedtls_certinfo branch 2 times, most recently from 3478944 to 50a3213 Compare April 21, 2024 23:35
Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going anywhere soon or can we close this again? Having a draft PR queued up in a temp state does us no good.

@sergio-nsk
Copy link
Contributor Author

sergio-nsk commented May 2, 2024

I will fix and finish this PR. Just I am getting troubles with running and debugging the python tests locally.

@sergio-nsk sergio-nsk force-pushed the mbedtls_certinfo branch 2 times, most recently from f655372 to 6b14447 Compare May 15, 2024 00:09
@sergio-nsk sergio-nsk marked this pull request as ready for review May 15, 2024 00:09
@sergio-nsk sergio-nsk requested a review from bagder May 15, 2024 02:56
@bagder
Copy link
Member

bagder commented May 24, 2024

I think you want something like this?

diff --git a/tests/test1275.pl b/tests/test1275.pl
index 47ce799578..353391d2f3 100755
--- a/tests/test1275.pl
+++ b/tests/test1275.pl
@@ -30,10 +30,11 @@ my @m = `git ls-files -- $root`;
 my $errors;
 
 my %accepted=('curl' => 1,
               'libcurl' => 1,
               'macOS' => 1,
+              'mbedTLS' => 1,
               'c-ares' => 1);
 
 sub checkfile {
     my ($f) = @_;
     chomp $f;

@bagder bagder removed the needs-info label May 24, 2024
@bagder bagder closed this in 35c0117 Jun 19, 2024
@bagder
Copy link
Member

bagder commented Jun 19, 2024

Thanks!

sergio-nsk added a commit to snxd/curl that referenced this pull request Jul 9, 2024
sergio-nsk added a commit to snxd/curl that referenced this pull request Jul 9, 2024
sergio-nsk added a commit to snxd/curl that referenced this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration tests TLS
Development

Successfully merging this pull request may close these issues.

None yet

2 participants