Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix detection of OpenSSL 1.1.1 or later in curl_sha512_256.c #13208

Closed
wants to merge 1 commit into from

Conversation

pghmcfc
Copy link
Contributor

@pghmcfc pghmcfc commented Mar 27, 2024

Use the same OPENSSL_VERSION_NUMBER comparison as in lib/vtls/openssl.c.

As it stands, builds using an OpenSSL 1.1.0 release fail due to trying to use the unavailable symbol EVP_sha512_256.

Use the same OPENSSL_VERSION_NUMBER comparison as in
lib/vtls/openssl.c.
@bagder
Copy link
Member

bagder commented Mar 27, 2024

/cc @Karlson2k

@Karlson2k
Copy link
Contributor

I made detection according to the OpenSSL documentation.
If the symbol is really missing I think the fix is correct.
As libcurl has the plan B (the local version), it's safer to merge this PR as in the worst case it would just lower the performance.

@pghmcfc
Copy link
Contributor Author

pghmcfc commented Mar 28, 2024

The version number would be correct as per the current numbering documentation. However, this changed with OpenSSL 3.x - the documentation for OpenSSL 1.x was slightly different: https://www.openssl.org/docs/man1.1.1/man3/OPENSSL_VERSION_NUMBER.html

@bagder bagder closed this in c77bdf1 Mar 28, 2024
@bagder
Copy link
Member

bagder commented Mar 28, 2024

Thanks!

@pghmcfc pghmcfc deleted the evp_sha512_256 branch March 28, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants