New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for OpenSSL 1.1.x on windows #1322

wants to merge 2 commits into
base: master


None yet
4 participants

weltling commented Mar 10, 2017

As pointed out in #1201 already, the OpenSSL 1.1.x lib names have changed, which as consequence makes impossible to link cURL with OpenSSL > 1.0.2. While the aforementioned PR suggested to make lib names configurable, it were also dicussed to first care about the build process present currently. This PR goes for this, the library names are determined by checking the physical existence of the certain files. The newer OpenSSL libs are preferred, while in general there's no change to the current build approach. The only condition is, that the DEVEL dir has to contain either one or the other set of libs, not both at once.


This comment has been minimized.

mention-bot commented Mar 10, 2017

@weltling, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @mback2k and @msnelling to be potential reviewers.

USE_SSL = true
SSL = dll
!ELSEIF "$(WITH_SSL)"=="static"
!IF EXISTS("$(DEVEL_LIB)\libssl.lib")
SSL_LIBS = libssl.lib libcrypto.lib ws2_32.lib crypt32.lib gdi32.lib user32.lib crypt32.lib

This comment has been minimized.


jay Mar 10, 2017


crypt32.lib is twice and also why ws2_32, is that needed?

This comment has been minimized.


weltling Mar 10, 2017


Indeed, my typo. Too much of makefiles today :) I was basically refering to, but i see now the ws2_32 and advapi32 are added with WIN_LIBS, so we should be all fine with accordance to the doc.


This comment has been minimized.


rodwiddowson commented Mar 13, 2017

FWIW, I just pulled this down and did a build - changed my build to not do anything special for OpenSSL and it worked a treat.

@jay jay closed this in db87bcf Mar 13, 2017


This comment has been minimized.


jay commented Mar 13, 2017

Thanks guys

@lock lock bot locked as resolved and limited conversation to collaborators May 24, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.