Skip to content

NTLM_WB: drop support - #13249

Closed
bagder wants to merge 3 commits into
masterfrom
bagder/rm-ntlm_wb
Closed

NTLM_WB: drop support#13249
bagder wants to merge 3 commits into
masterfrom
bagder/rm-ntlm_wb

Conversation

@bagder

@bagder bagder commented Mar 31, 2024

Copy link
Copy Markdown
Member

The feature has not worked for months and has been marked as DEPRECATED for six+ months.

@bagder
NTLM_WB: drop support
75957ca 
The feature has not worked for months and has been marked as DEPRECATED
for six+ months.
@github-actions github-actions Bot added the tests label Mar 31, 2024
@bagder bagder added the feature-window A merge of this requires an open feature window label Apr 1, 2024
@bagder bagder closed this in 50def7c Apr 8, 2024
@bagder
bagder deleted the bagder/rm-ntlm_wb branch April 8, 2024 11:59
vszakats added a commit to vszakats/curl that referenced this pull request Sep 9, 2024
@vszakats
tests: delete NTLM_WB remains
a4c4413 
Follow-up to 50def7c curl#13249
@vszakats vszakats mentioned this pull request Sep 9, 2024
Closed
vszakats added a commit that referenced this pull request Sep 10, 2024
@vszakats
NTLM_WB: delete remains in tests, docs updates
805bbf7 
Also update more docs to reflect the removal of NTLM_WB.

Follow-up to 50def7c #13249
Closes #14832
@vszakats vszakats mentioned this pull request Nov 13, 2024
Closed
4 tasks
vszakats added a commit to vszakats/curl that referenced this pull request Nov 23, 2024
@vszakats
drop unused HAVE_SYS_WAIT_H
87853d5 
Follow-up to 50def7c curl#13249
vszakats added a commit that referenced this pull request Dec 16, 2024
@vszakats
build: drop unused feature macros, update exception list
dc874d4 
- cmp-config.pl: add remaining exceptions. Sort list.

- drop unused `HAVE_SYS_WAIT_H`.
  Follow-up to 50def7c #13249

- drop unused `HAVE_FCHMOD`.
  Follow-up to 03cb1ff #12395

- autotools: stop promoting variables to macros:
  `USE_NGTCP2_CRYPTO_*`, `USE_NGTCP2_H3`, `USE_OPENSSL_H3`,
  `HAVE_LIBRESSL`.
  They are not used in the source.

- cmake: drop unused `HAVE_O_NONBLOCK`,
  `HAVE_DISABLED_NONBLOCKING`.

- lib: drop `NEED_MALLOC_H`.
  It was used in manual-build cases for Amiga/MS-DOS/Windows/WinCE, but
  never by autotools/cmake, thus apparently unnecessary.

- lib: drop unused `NEED_MEMORY_H`.

- lib: simplify classic mac feature guards,
  drop `HAVE_EXTRA_STRICMP_H` and `HAVE_EXTRA_STRDUP_H`.

- autotools: drop unused `HAVE_GETHOSTBYNAME` detection.

- autotools: drop unused OpenSSL feature tests:
  `HAVE_ERR_H`, `HAVE_PEM_H`, `HAVE_RSA_H`

- autotools: drop unused OpenSSL feature tests:
  `HAVE_X509_H`, `HAVE_CRYPTO_H`, `HAVE_SSL_H`.

  They performed a fallback check when the primary check missed
  `openssl/x509.h`. Though if any other prefixed headers were found,
  OpenSSL is already assumed detected.

  The fallback check was looking for 3 unprefixed OpenSSL headers, and
  if all found, marked OpenSSL found internally, but did not promote
  it to `curl_config.h` via `USE_OPENSSL`. Meaning it either didn't do
  anything or may have continued with an inconsistent state.
  Added in d99c20f (2008)

  At the time, there was an extra `AC_DEFINE(USE_SSLEAY, 1 ...` logic
  after this code, which kicked in in the fallback case, but that code
  was deleted in 709cf76 (2015)

  Follow-up to 709cf76

- autotools: drop `AC_SUBST()` where the value is explicitly set anyway
  and the macro is unused.

- autotools: replace `AC_SUBST(VAR, 1)` with local variable assigments,
  where the `@VAR@` macro is unused. Also dedupe the local variable if
  there was a parallel one used for the same purpose.

- autotools: drop local feature variables that were never used.

- autotools: drop unused `CURL_CHECK_OPTION_NTLM_WB`,
  `CURL_CHECK_NTLM_WB`.
  Also stop setting unused `NTLM_WB_ENABLED` macro for VMS.
  Follow-up to 50def7c #13249

- autotools: drop unused `PKGADD_*`.
  Follow-up to bae0d47 #3331

- autotools: drop unused `CURL_NETWORK_LIBS`.
  Follow-up to 3af75e1 #14697

Closes #15577
@vszakats vszakats mentioned this pull request Mar 12, 2025
Closed
vszakats added a commit that referenced this pull request Mar 12, 2025
@vszakats
ntlm: merge ntlm.h into ntlm.c
07f984a 
It's the only user since dropping NTLM_WB support.

Follow-up to 50def7c #13249

Closes #16690
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
@vszakats @pps83
NTLM_WB: delete remains in tests, docs updates
a46feb4 
Also update more docs to reflect the removal of NTLM_WB.

Follow-up to 50def7c curl#13249
Closes curl#14832
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
@vszakats @pps83
build: drop unused feature macros, update exception list
b673a9a 
- cmp-config.pl: add remaining exceptions. Sort list.

- drop unused `HAVE_SYS_WAIT_H`.
  Follow-up to 50def7c curl#13249

- drop unused `HAVE_FCHMOD`.
  Follow-up to 03cb1ff curl#12395

- autotools: stop promoting variables to macros:
  `USE_NGTCP2_CRYPTO_*`, `USE_NGTCP2_H3`, `USE_OPENSSL_H3`,
  `HAVE_LIBRESSL`.
  They are not used in the source.

- cmake: drop unused `HAVE_O_NONBLOCK`,
  `HAVE_DISABLED_NONBLOCKING`.

- lib: drop `NEED_MALLOC_H`.
  It was used in manual-build cases for Amiga/MS-DOS/Windows/WinCE, but
  never by autotools/cmake, thus apparently unnecessary.

- lib: drop unused `NEED_MEMORY_H`.

- lib: simplify classic mac feature guards,
  drop `HAVE_EXTRA_STRICMP_H` and `HAVE_EXTRA_STRDUP_H`.

- autotools: drop unused `HAVE_GETHOSTBYNAME` detection.

- autotools: drop unused OpenSSL feature tests:
  `HAVE_ERR_H`, `HAVE_PEM_H`, `HAVE_RSA_H`

- autotools: drop unused OpenSSL feature tests:
  `HAVE_X509_H`, `HAVE_CRYPTO_H`, `HAVE_SSL_H`.

  They performed a fallback check when the primary check missed
  `openssl/x509.h`. Though if any other prefixed headers were found,
  OpenSSL is already assumed detected.

  The fallback check was looking for 3 unprefixed OpenSSL headers, and
  if all found, marked OpenSSL found internally, but did not promote
  it to `curl_config.h` via `USE_OPENSSL`. Meaning it either didn't do
  anything or may have continued with an inconsistent state.
  Added in d99c20f (2008)

  At the time, there was an extra `AC_DEFINE(USE_SSLEAY, 1 ...` logic
  after this code, which kicked in in the fallback case, but that code
  was deleted in 709cf76 (2015)

  Follow-up to 709cf76

- autotools: drop `AC_SUBST()` where the value is explicitly set anyway
  and the macro is unused.

- autotools: replace `AC_SUBST(VAR, 1)` with local variable assigments,
  where the `@VAR@` macro is unused. Also dedupe the local variable if
  there was a parallel one used for the same purpose.

- autotools: drop local feature variables that were never used.

- autotools: drop unused `CURL_CHECK_OPTION_NTLM_WB`,
  `CURL_CHECK_NTLM_WB`.
  Also stop setting unused `NTLM_WB_ENABLED` macro for VMS.
  Follow-up to 50def7c curl#13249

- autotools: drop unused `PKGADD_*`.
  Follow-up to bae0d47 curl#3331

- autotools: drop unused `CURL_NETWORK_LIBS`.
  Follow-up to 3af75e1 curl#14697

Closes curl#15577
pps83 pushed a commit to pps83/curl that referenced this pull request Apr 26, 2025
@vszakats @pps83
ntlm: merge ntlm.h into ntlm.c
26bcf97 
It's the only user since dropping NTLM_WB support.

Follow-up to 50def7c curl#13249

Closes curl#16690
@weihanglo weihanglo mentioned this pull request Nov 20, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

authentication cmdline tool feature-window A merge of this requires an open feature window libcurl API tests

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@bagder