cmake: check fseeko after detecting HAVE_FILE_OFFSET_BITS - #13264
Closed
SirLynix wants to merge 2 commits into
Closed
cmake: check fseeko after detecting HAVE_FILE_OFFSET_BITS#13264SirLynix wants to merge 2 commits into
SirLynix wants to merge 2 commits into
Conversation
vszakats
reviewed
Apr 2, 2024
Co-authored-by: Viktor Szakats <vszakats@users.noreply.github.com>
bagder
approved these changes
Apr 8, 2024
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Android,
fseekois defined as is (I omitted other functions for clarity):Which means that on Android 32bits (armv7), fseeko is only available in 32bits mode, if
__USE_FILE_OFFSET64(_FILE_OFFSET_BITS=64) is set thenfseekois not available.CMake detects
fseekoas available because_FILE_OFFSET_BITS=64is not yet defined when it tests for this function existence, but then it defines_FILE_OFFSET_BITS=64which makesfseekounavailable and fails compilation:A simple fix is to test for
fseekoexistence after testingHAVE_FILE_OFFSET_BITSand especially aftertested here
Fix #12086 for good