multi: timeout handles even without connection - #13276
Closed
bagder wants to merge 1 commit into
Closed
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Member
Author
|
This fix is an improvement but does not fix all the timeout issues we have detected with pipewait. I will probably still merge this independently of that. I don't know when I will get opportunity to work and fix it further. |
When there is a "change" in a multi handle and pending handles are moved back to the main list to be retested if they can proceed further (for example a previous transfer completed or a connection has a confirmed multiplexed state), the timeout check in multi_runsingle() would not trigger because it required an established connection. This could make a pending tranfer go back to pending state even though it had been "in progress" for a longer time than permitted. By removing the requirement for an associated connection, the timeout check will be done proper even for transfers that has not yet been assigned one. Ref #13227 Reported-by: Rahul Krishna M Closes #13276
bagder
force-pushed
the
bagder/timeout-wo-connections
branch
from
April 12, 2024 21:31
ba219df to
dd47d69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a "change" in a multi handle and pending handles are moved back to the main list to be retested if they can proceed further (for example a previous transfer completed or a connection has a confirmed multiplexed state), the timeout check in multi_runsingle() would not trigger because it required an established connection.
This could make a pending tranfer go back to pending state even though it had been "in progress" for a longer time than permitted. By removing the requirement for an associated connection, the timeout check will be done proper even for transfers that has not yet been assigned one.
Fixes #13227
Reported-by: Rahul Krishna M