Fix cppcheck reports:

[serval2412]

[tests/libtest/lib1900.c:182]: (style) Array index 'handlenum' is used before limits check.
[docs/examples/sepheaders.c:65]: (error) Resource leak: headerfile

[captain-caveman2k]

Hi Julien,

Many thanks.

I've pushed your modification to sepheaders.c but have a question for you about the modification to lib1900.c:

Is the check for 'handlenum < num_handles' needed in that second if statement, in order to pass cppcheck, given that the same check happens a few lines up and the values of 'handlenum' and 'num_handles' are not modified in between the two if statements?

Unless I've missed something I don't think it is needed from a logic point of view.

Kind Regards

Steve

[serval2412]

You're right, I think cppcheck isn't smart enough to detect that the check already exists some line above.
In this case, you may perhaps remove the dup check in the line cppcheck reported?

[captain-caveman2k]

Hi again,

I think the check being in the second part of the second if statement may be confusing cppcheck as well :(

Are you able to test this theory and produce a patch if it is successful - as I don't run cppcheck personally?

Many thanks

Steve

[serval2412]

Ok if I do this:

•  if(msnow - mslast >= urltime[handlenum] && handlenum < num_handles) {
  

•  if((msnow - mslast) >= urltime[handlenum]) {
  

  everything is alright for cppcheck.

[captain-caveman2k]

Cheers Julien,

I'll prepare a patch on your behalf and push it.

Fyi: Daniel has started to use Coverity to scan the source code over recent months and I've just been looking at the cppcheck website, whilst compiling various patches, so I will try cppcheck myself over the next few days.

Thanks again

Steve

[serval2412]

Great!
cppcheck is really simple to use and is free!
cppcheck --enable=all
you can also produce html report, I use this for LibreOffice (see https://wiki.documentfoundation.org/Development/Cppcheck)

[captain-caveman2k]

Pushed as commit ee0941a.