OS400: fix shellcheck warnings in scripts - #13309
Closed
vszakats wants to merge 6 commits into
Closed
Conversation
3 tasks
vszakats
changed the title
vszakats
force-pushed
the
ci-shellcheck-os400-2
branch
from
April 8, 2024 09:39
19300d9 to
254411e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
vszakats
force-pushed
the
ci-shellcheck-os400-2
branch
from
April 9, 2024 17:54
f3af4ba to
2df9488
Compare
bagder
approved these changes
Apr 11, 2024
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Apr 13, 2024
Build scripts must be executed by the os/400 shell (sh), not bash which is a PASE program: The `-ot` non-POSIX test extension works in os/400 as well. Ref: libssh2/libssh2#1364 (comment) Follow-up to 8a622ba curl#13309 Assisted-by: Patrick Monnerat Closes #xxxxx
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
$()instead of backticks, and re-arrange double-quotes inside.|| exit 1tocdcalls. (could be dropped by usingset -eu.)-nto a fewifs.{} >(as shellcheck recommended).-otfeature.$(expr \,$(dirname \)Also enable CI checks for OS/400 shell scripts.
Ref: #13307
Closes #13309
Added one FIXME ininitscript.shwhere there is a single use of a non-POSIXexpression
[ "${1}" -ot "${2}" ]causing a warning. We can fix this by bumpingthe shebangs to bash, or come up with a POSIX alternative.
/cc @monnerat