build: prefer USE_IPV6 macro internally (was: ENABLE_IPV6) - #13349
Closed
vszakats wants to merge 2 commits into
Closed
build: prefer USE_IPV6 macro internally (was: ENABLE_IPV6)#13349vszakats wants to merge 2 commits into
USE_IPV6 macro internally (was: ENABLE_IPV6)#13349vszakats wants to merge 2 commits into
Conversation
Closes #xxxxx
Member
Gets a 👍 from me! |
vszakats
changed the title
ENABLE_IPV6 macro in MSVC buildsUSE_IPV6 macro name internally (was: ENABLE_IPV6)
vszakats
changed the title
USE_IPV6 macro name internally (was: ENABLE_IPV6)USE_IPV6 macro internally (was: ENABLE_IPV6)
vszakats
added a commit
to vszakats/curl
that referenced
this pull request
Apr 13, 2024
It looks like the OpenVMS script `config_h.com` is parsing the config header generated by autotools. Let's make it look for the macro name we now universally use across the codebase. Follow-up to e411c98 curl#13349 Closes #xxxxx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch, two macros were used to guard IPv6 features in curl
sources:
ENABLE_IPV6andUSE_IPV6. This patch makes the source usethe latter for consistency with other similar switches.
-DENABLE_IPV6remains accepted for compatibility as a synonym for-DUSE_IPV6, when passed to the compiler.ENABLE_IPV6also remains the name of the CMake andMakefile.vcoptions to control this feature.
Closes #13349
Ideally I would prefer to switch over all uses in C from
ENABLE_IPV6toUSE_IPV6, which fits the naming used for all other public feature macros.Then leave
ENABLE_IPV6as a compatibility macro that merely setsUSE_IPV6. Thoughts?