lib: merge ENABLE_QUIC C macro into USE_HTTP3 - #13352
Closed
vszakats wants to merge 1 commit into
Closed
Conversation
They were defined right next to each other, and used interchangeably afterwards. Closes #xxxxx
Contributor
|
There is a several ways to build http3 with curl. |
Member
Author
|
My patch doesn't change how these features are enabled / selected. OpenSSL + nghttp3 can be enabled the same way as before: (If someone was using |
Contributor
|
Thank you for clearing it up! |
bagder
approved these changes
Apr 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this patch
lib/curl_setup.hdefined these two macros rightnext to each other, then the source code used them interchangeably.
After this patch,
USE_HTTP3guards all HTTP/3 / QUIC features.(Like
USE_HTTP2does for HTTP/2.)ENABLE_QUICis no longer used.This patch doesn't change the way HTTP/3 is enabled via autotools
or CMake. Builders who enabled HTTP/3 manually by defining both of
these macros via
CPPFLAGScan now delete-DENABLE_QUIC.Closes #13352
I could not spot the difference between the meaning of these two macros
in context of curl's HTTP/3 support. Let me know if I missed something.