Curl_client_read: init two variables to avoid using them uninited - #13419
Closed
bagder wants to merge 2 commits into
Closed
Curl_client_read: init two variables to avoid using them uninited#13419bagder wants to merge 2 commits into
bagder wants to merge 2 commits into
Conversation
Within the function we trace the values independently of the Curl_creader_read() returning error or not, which could leave them uninitialized. Spotted by CodeSonar
Contributor
|
Hmm, I do prefer - maybe just taste - to have a call with Which probably means the fix should be in |
Member
Author
|
Like this? |
icing
approved these changes
Apr 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Within the function we trace the values independently of the Curl_creader_read() returning error or not, which could leave them uninitialized.
Spotted by CodeSonar