Skip to content

mbedTLS: Implemented CURLOPT_SSL_CIPHER_LIST option - #13442

Closed
jan2000 wants to merge 1 commit into
curl:masterfrom
jan2000:mbedtls-add-ssl-cipher-list
Closed

mbedTLS: Implemented CURLOPT_SSL_CIPHER_LIST option#13442
jan2000 wants to merge 1 commit into
curl:masterfrom
jan2000:mbedtls-add-ssl-cipher-list

Conversation

@jan2000

@jan2000 jan2000 commented Apr 22, 2024

Copy link
Copy Markdown
Contributor

Use a lookup list to set the cipher suites, allowing the ciphers to be set by either openssl or IANA names.

To keep the binary size of the lookup list down we compress each entry in the cipher list down to 2 + 6 bytes using the C preprocessor.

@github-actions github-actions Bot added tests CI Continuous Integration labels Apr 22, 2024
Comment thread lib/vtls/mbedtls.c Outdated
Comment thread lib/vtls/mbedtls.c Outdated
Comment thread lib/vtls/mbedtls.c Outdated
Comment thread lib/vtls/mbedtls.c Outdated
Comment thread lib/vtls/cipher_suite.c Outdated
@jan2000
jan2000 force-pushed the mbedtls-add-ssl-cipher-list branch from 326d17b to 8ed1d8b Compare April 22, 2024 21:52
@bagder

bagder commented Apr 23, 2024

Copy link
Copy Markdown
Member

Ah, the test case got a merge conflict now as another commit unfortunately was merged that used the same number.

@jan2000
jan2000 force-pushed the mbedtls-add-ssl-cipher-list branch from 8ed1d8b to ac18150 Compare April 23, 2024 13:58
@jan2000

jan2000 commented Apr 23, 2024

Copy link
Copy Markdown
Contributor Author

Ok, I have rebased to latest master and updated to test 3205.

Comment thread lib/vtls/cipher_suite.c Outdated
vszakats added a commit to vszakats/curl that referenced this pull request Apr 23, 2024
Pointed-out-by: jan2000 on github
Ref: curl#13442 (comment)
Closes #xxxxx
Use a lookup list to set the cipher suites, allowing the
ciphers to be set by either openssl or IANA names.

To keep the binary size of the lookup list down we compress
each entry in the cipher list down to 2 + 6 bytes using the
C preprocessor.
@jan2000
jan2000 force-pushed the mbedtls-add-ssl-cipher-list branch from ac18150 to 0a38c82 Compare April 23, 2024 15:54
vszakats added a commit that referenced this pull request Apr 24, 2024
Avoid clashing static function names by namespacing them.

Pointed-out-by: Jan Venekamp
Ref: #13442 (comment)
Closes #13450
@bagder bagder closed this in fba9afe Apr 24, 2024
@bagder

bagder commented Apr 24, 2024

Copy link
Copy Markdown
Member

Thanks!

@jan2000
jan2000 deleted the mbedtls-add-ssl-cipher-list branch May 4, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous Integration tests

Development

Successfully merging this pull request may close these issues.

3 participants