Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: fall back on SSL_ERROR_* string when no error detail #1348

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented Mar 22, 2017

  • If SSL_get_error is called but no extended error detail is available
    then show that SSL_ERROR_* as a string.

Prior to this change there was some inconsistency in that case: the
SSL_ERROR_* code may or may not have been shown, or may have been shown
as unknown even if it was known.

Ref: #1300

Closes #xxxx

- If SSL_get_error is called but no extended error detail is available
  then show that SSL_ERROR_* as a string.

Prior to this change there was some inconsistency in that case: the
SSL_ERROR_* code may or may not have been shown, or may have been shown
as unknown even if it was known.

Ref: curl#1300

Closes #xxxx
@jay jay added the TLS label Mar 22, 2017
@mention-bot
Copy link

@jay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ghedo, @captain-caveman2k and @bagder to be potential reviewers.

Copy link
Member

@MarcelRaad MarcelRaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything that can help getting more/better/SOMETHING error messages from openssl is a win in my book!

@jay jay closed this in b999d35 Mar 23, 2017
@jay jay deleted the ossl_errstr_fallback branch March 23, 2017 21:23
@jay
Copy link
Member Author

jay commented Mar 23, 2017

Thanks for the review guys

@lock lock bot locked as resolved and limited conversation to collaborators May 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

4 participants