openssl: fall back on SSL_ERROR_* string when no error detail #1348

Closed
wants to merge 1 commit into
from

Projects

None yet

4 participants

@jay
Owner
jay commented Mar 22, 2017
  • If SSL_get_error is called but no extended error detail is available
    then show that SSL_ERROR_* as a string.

Prior to this change there was some inconsistency in that case: the
SSL_ERROR_* code may or may not have been shown, or may have been shown
as unknown even if it was known.

Ref: #1300

Closes #xxxx

@jay jay openssl: fall back on SSL_ERROR_* string when no error detail
- If SSL_get_error is called but no extended error detail is available
  then show that SSL_ERROR_* as a string.

Prior to this change there was some inconsistency in that case: the
SSL_ERROR_* code may or may not have been shown, or may have been shown
as unknown even if it was known.

Ref: curl#1300

Closes #xxxx
0a5dc72
@jay jay added the SSL/TLS label Mar 22, 2017

@jay, thanks for your PR! By analyzing the history of the files in this pull request, we identified @ghedo, @captain-caveman2k and @bagder to be potential reviewers.

@MarcelRaad

👍

@bagder
bagder approved these changes Mar 22, 2017 View changes

Everything that can help getting more/better/SOMETHING error messages from openssl is a win in my book!

@jay jay added a commit that closed this pull request Mar 23, 2017
@jay jay openssl: fall back on SSL_ERROR_* string when no error detail
- If SSL_get_error is called but no extended error detail is available
  then show that SSL_ERROR_* as a string.

Prior to this change there was some inconsistency in that case: the
SSL_ERROR_* code may or may not have been shown, or may have been shown
as unknown even if it was known.

Ref: #1300

Closes #1348
b999d35
@jay jay closed this in b999d35 Mar 23, 2017
@jay jay deleted the jay:ossl_errstr_fallback branch Mar 23, 2017
Owner
jay commented Mar 23, 2017

Thanks for the review guys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment