Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/README: make "Run" section foolproof #1352

wants to merge 1 commit into from


Copy link

This is probably obvious to linux users, but wasn't to me as a mainly Windows user when I first read this and the error messages are not very helpful ("don't know how to make target test" if you forget ./configure and "cannot get curl version" if you forget make).

curl must be built before building the tests.
Copy link

@MarcelRaad, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bagder, @dfandrich and @yangtse to be potential reviewers.

bagder approved these changes Mar 23, 2017
Copy link

@bagder bagder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@MarcelRaad MarcelRaad deleted the tests_readme_run branch March 24, 2017 07:24
Copy link
Member Author

Thanks @bagder !

@lock lock bot locked as resolved and limited conversation to collaborators May 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants