Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Curl_dyn_vaddf should return error instead of OK if memory fails #13533

Closed

Conversation

MonkeybreadSoftware
Copy link
Contributor

I think you meant CURLE_OUT_OF_MEMORY to report if you are out of memory for vaprintf returning NULL.

Looks strange to return CURLE_OK after calling Curl_dyn_free.

I think you meant CURLE_OUT_OF_MEMORY to report if you are out of memory for vaprintf returning NULL.

Looks strange to return CURLE_OK after calling Curl_dyn_free.
Copy link
Member

@danielgustafsson danielgustafsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants