Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asyn-thread: fix Curl_thread_create result check #13542

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented May 6, 2024

  • Compare to curl_thread_t_null instead of 0 for error.

Currently for both supported thread libraries (pthreads and Windows) curl_thread_t_null is defined as 0. However, the pattern throughout the code is to check against curl_thread_t_null and not 0 since for posterity some thread library may not use 0 for error.

Closes #xxxx

- Compare to curl_thread_t_null instead of 0 for error.

Currently for both supported thread libraries (pthreads and Windows)
curl_thread_t_null is defined as 0. However, the pattern throughout the
code is to check against curl_thread_t_null and not 0 since for
posterity some thread library may not use 0 for error.

Closes #xxxx
@jay jay added the tidy-up label May 6, 2024
@github-actions github-actions bot added the name lookup DNS and related tech label May 6, 2024
@jay jay closed this in 62ae1f1 May 7, 2024
@jay jay deleted the fix_createthread_retval branch May 7, 2024 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
name lookup DNS and related tech tidy-up
Development

Successfully merging this pull request may close these issues.

None yet

1 participant