lib: clear the easy handle's saved errno before transfer #13574
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clear data->state.os_errno before transfer. - Explain the change in behavior in the CURLINFO_OS_ERRNO doc. - Add to the CURLINFO_OS_ERRNO doc the list of libcurl network-related errors that may cause the errno to be saved. data->state.os_errno is saved before libcurl returns a network-related failure such as connection failure. It is accessible to the user via CURLINFO_OS_ERRNO so they can get more information about the failure. Prior to this change it wasn't cleared before transfer so if a user retrieved the saved errno it could be from a previous transfer. That is because an errno is not always saved for network-related errors. Closes #xxxxx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clear data->state.os_errno before transfer.
Explain the change in behavior in the CURLINFO_OS_ERRNO doc.
Add to the CURLINFO_OS_ERRNO doc the list of libcurl network-related errors that may cause the errno to be saved.
data->state.os_errno is saved before libcurl returns a network-related failure such as connection failure. It is accessible to the user via CURLINFO_OS_ERRNO so they can get more information about the failure.
Prior to this change it wasn't cleared before transfer so if a user retrieved the saved errno it could be from a previous transfer. That is because an errno is not always saved for network-related errors.
Closes #xxxxx