hsts: explicitly skip blank lines #13603
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bagder
reviewed
May 13, 2024
lib/hsts.c
Outdated
| if(*lineptr == '#') | ||
| /* skip commented lines */ | ||
| if((*lineptr == '#') || strlen(lineptr) == 0) | ||
| /* skip empty or commented lines */ |
There was a problem hiding this comment.
Since Curl_get_line() works hard to return lines with a trailing newline, should this perhaps rather check for <= 1 ?
There was a problem hiding this comment.
That's a good point, it should. Rebased the PR with this fix.
danielgustafsson
force-pushed
the
dg-hsts-emptyline
branch
from
b0fc6c0 to
0d6ee9a
Compare
Keep blank lines or lines containing only whitespace to make it all the way to the more expensive sscanf call in hsts_add.
danielgustafsson
force-pushed
the
dg-hsts-emptyline
branch
from
0d6ee9a to
f1ff8d8
Compare
bagder
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep blank lines or lines containing only whitespace to make it all the way to the more expensive sscanf call in hsts_add.