Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warnless: delete orphan declarations #13639

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented May 14, 2024

Follow-up to 358f7e7 #11932
Closes #13639


These functions had a point not just for the Intel compiler but for envs that don't compile FD_SET()/FS_ISSET() cleanly with -Wsign-conversion. E.g. OmniOS and older Cygwin.
Ref: #13489
Ref:

#if defined(__GNUC__)
#pragma GCC diagnostic push
#pragma GCC diagnostic ignored "-Wsign-conversion"
#endif
FD_SET(sockfd, &errfd); /* always check for error */
if(for_recv) {
FD_SET(sockfd, &infd);
}
else {
FD_SET(sockfd, &outfd);
}
#if defined(__GNUC__)
#pragma GCC diagnostic pop
#endif

@vszakats vszakats closed this in 0c890d9 May 14, 2024
@vszakats vszakats deleted the warnless-tidy branch May 14, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants