New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conncache: make hashkey avoid malloc #1365

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@bagder
Member

bagder commented Mar 28, 2017

... to make it much faster. Idea developed with primepie on IRC.

conncache: make hashkey avoid malloc
... to make it much faster. Idea developed with primepie on IRC.
@mention-bot

This comment has been minimized.

Show comment
Hide comment
@mention-bot

mention-bot Mar 28, 2017

@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @linusnielsen and @mkauf to be potential reviewers.

mention-bot commented Mar 28, 2017

@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @linusnielsen and @mkauf to be potential reviewers.

DEBUGASSERT(len > 32);
/* put the number first so that the hostname gets cut off if too long */
snprintf(buf, len, "%ld%s", conn->port, hostname);

This comment has been minimized.

@MarcelRaad

MarcelRaad Mar 28, 2017

Member

Isn't snprintf C99? I believe MSVC versions prior to 2015 only have a _snprintf that doesn't append a '\0' if the string gets truncated.

@MarcelRaad

MarcelRaad Mar 28, 2017

Member

Isn't snprintf C99? I believe MSVC versions prior to 2015 only have a _snprintf that doesn't append a '\0' if the string gets truncated.

This comment has been minimized.

@bagder

bagder Mar 28, 2017

Member

That's one of the reasons why have our own set of *printf() implementations and snprintf comes from here: https://github.com/curl/curl/blob/master/lib/curlx.h#L105

If you check the code closer you'll see that we already use snprintf() in numerous places thanks to this.

@bagder

bagder Mar 28, 2017

Member

That's one of the reasons why have our own set of *printf() implementations and snprintf comes from here: https://github.com/curl/curl/blob/master/lib/curlx.h#L105

If you check the code closer you'll see that we already use snprintf() in numerous places thanks to this.

This comment has been minimized.

@MarcelRaad

MarcelRaad Mar 28, 2017

Member

Ah, great! I forgot about that.

@MarcelRaad

MarcelRaad Mar 28, 2017

Member

Ah, great! I forgot about that.

@MarcelRaad

Good idea!

@@ -128,7 +128,8 @@ void Curl_conncache_destroy(struct conncache *connc)
}
/* returns an allocated key to find a bundle for this connection */

This comment has been minimized.

@bagder

bagder Mar 28, 2017

Member

I'll fix the comment too.

@bagder

bagder Mar 28, 2017

Member

I'll fix the comment too.

@bagder bagder closed this in 2066072 Mar 28, 2017

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Mar 28, 2017

Member

thanks for the review!

Member

bagder commented Mar 28, 2017

thanks for the review!

@bagder bagder deleted the bagder/improve-hashkey branch Mar 29, 2017

@lock lock bot locked as resolved and limited conversation to collaborators May 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.