GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
... to make it much faster. Idea developed with primepie on IRC.
conncache: make hashkey avoid malloc
@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @linusnielsen and @mkauf to be potential reviewers.
Isn't snprintf C99? I believe MSVC versions prior to 2015 only have a _snprintf that doesn't append a '\0' if the string gets truncated.
That's one of the reasons why have our own set of *printf() implementations and snprintf comes from here: https://github.com/curl/curl/blob/master/lib/curlx.h#L105
If you check the code closer you'll see that we already use snprintf() in numerous places thanks to this.
Ah, great! I forgot about that.
I'll fix the comment too.
thanks for the review!