conncache: make hashkey avoid malloc #1365
Conversation
... to make it much faster. Idea developed with primepie on IRC.
|
@bagder, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @linusnielsen and @mkauf to be potential reviewers. |
| DEBUGASSERT(len > 32); | ||
|
|
||
| /* put the number first so that the hostname gets cut off if too long */ | ||
| snprintf(buf, len, "%ld%s", conn->port, hostname); |
There was a problem hiding this comment.
Isn't snprintf C99? I believe MSVC versions prior to 2015 only have a _snprintf that doesn't append a '\0' if the string gets truncated.
There was a problem hiding this comment.
That's one of the reasons why have our own set of *printf() implementations and snprintf comes from here: https://github.com/curl/curl/blob/master/lib/curlx.h#L105
If you check the code closer you'll see that we already use snprintf() in numerous places thanks to this.
There was a problem hiding this comment.
Ah, great! I forgot about that.
| @@ -128,7 +128,8 @@ void Curl_conncache_destroy(struct conncache *connc) | |||
| } | |||
|
|
|||
| /* returns an allocated key to find a bundle for this connection */ | |||
There was a problem hiding this comment.
I'll fix the comment too.
|
thanks for the review! |
... to make it much faster. Idea developed with primepie on IRC.