pytest, fixes for recent python, add FTP tests - #13661
Closed
icing wants to merge 5 commits into
Closed
Conversation
Contributor
|
Shouldn't the ftp tests go into a new "tests/ftp/" directory? It's unexpected seeing ftp tests in a directory called "http".
|
Contributor
Author
That would be one idea. Or rename |
Member
|
I think the rustls.c fixes should be put into a separate PR to keep this one limited to the test suite. |
Contributor
Author
Done in #13670. |
Fixes: - in uds tests, abort also silently on os errors - be conservative on the h3 goaway duration - detect curl debug build and use in checks - fix caddy version check for slight difference under linux - set caddy default path fitting for linux - fix deprecation warnings in valid time checks FTP tests: - add '--with-test-vsftpd=path' to configure - use vsftpd default path suitable for linux - add test_30 with plain FTP tests - add test_31 with --ssl-reqd FTP tests - add vsftpd to linux GHA for pytest workflows
- fix rustls errors from CURLE_READ_ERROR to CURLE_RECV_ERROR - exclude some tests on h3 if not available in curl
icing
force-pushed
the
pytest-fixes-and-ftp
branch
from
May 17, 2024 11:27
6774439 to
8e7153a
Compare
Member
|
I propose |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
FTP tests: