Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: initialize BUILD_TESTING before first use #13668

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented May 16, 2024

Before this patch BUILD_TESTING was used once, then initialized, then
used again. This caused the curlu library not being built when relying
on an implicit BUILD_TESTING=ON setting, and ending up with a link
error when building the testdeps target.

It did not cause issues when BUILD_TESTING was explicitly set.

Move the initialization before the first use to fix it.

Regression from aace27b #12287

Closes #13668

Before this patch `BUILD_TESTING` was used once, then initialized, then
used again. This caused the `curlu` library not being built when relying
on an implicit `BUILD_TESTING=ON` setting, and ending up with a link
error when building the `testdeps` target.

It did not cause issues when `BUILD_TESTING` was explicitly set.

Move the initialization before the first use to fix it.

Closes #xxxxx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant