Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upgcc7: fix ‘*’ in boolean context, suggest ‘&&’ instead [-Wint-in-bool… #1371
Conversation
This comment has been minimized.
This comment has been minimized.
mention-bot
commented
Mar 30, 2017
@alagoutte, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yangtse, @bagder and @jay to be potential reviewers. |
bagder
added
the
build
label
Mar 30, 2017
bagder
approved these changes
Mar 30, 2017
Yes, there's really no point in actually doing the math there. |
bagder
closed this
in
244e0a3
Mar 30, 2017
This comment has been minimized.
This comment has been minimized.
Thanks! |
This comment has been minimized.
This comment has been minimized.
May be also update the comment ? So at this |
This comment has been minimized.
This comment has been minimized.
I don't think we need to. I think the comment explains the logic fine why we return what we do, even if it doesn't match the code exactly. Changing the comment to look like the code makes the language in the comment harder to follow I think? |
This comment has been minimized.
This comment has been minimized.
may be add different from sz*nmemb (ak sz && nmemb) |
This comment has been minimized.
This comment has been minimized.
The comment is based on the explanation in the man page:
... and |
alagoutte commentedMar 30, 2017
…-context]
May be also update the comment