Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix building with both md4 and md5 in unity mode #13737

Closed
wants to merge 2 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented May 21, 2024

Macro and static function names were colliding between
lib/md4.c and
lib/md5.c.

Fix it by namespacing these symbols.

Seen with a basic macOS build using these options:
-DCMAKE_UNITY_BUILD=ON -DCURL_USE_SECTRANSP=ON

Closes #13737

Macro and static function names were colliding between
`lib/md4.c` and
`lib/md5.c`.

Seen with a basic macOS build using these options:
-DCMAKE_UNITY_BUILD=ON -DCURL_USE_SECTRANSP=ON

Closes #xxxxx
@vszakats vszakats closed this in ca8cb24 May 22, 2024
@vszakats vszakats deleted the cmake-unity-md4-md5 branch May 22, 2024 12:19
@pps83
Copy link
Contributor

pps83 commented May 22, 2024

Finally! I think #define I is the piece of code I hate to most due to the buggy visual assist intellisense that keeps suggesting/replacing i with I because of that macro somewhere deep down in curl. define S should be fixed next :)

@vszakats
Copy link
Member Author

Well spotted, and there is also an R :)

Would you like to make a PR of this?

@pps83
Copy link
Contributor

pps83 commented May 22, 2024

Would you like to make a PR of this?

#13751

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants