New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Explain --fail-early does not imply --fail #1375

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jay
Member

jay commented Mar 31, 2017

I made a mistake in some scripts replacing --fail with --fail-early, not remembering the latter doesn't imply the former. You'd think I would know since it looks like I may have been one of the initial reviewers but I don't remember it.

For example I get a bunch of files using --fail-early --location --remote-name-all and they were all written even though one had failed. I think it's an easy mistake to make, and so it should be documented that it's for transfer errors and does not imply --fail but can be combined with it.

Not in this commit:
The short help could be modified as well, but it may be overkill?

 -f, --fail          Fail silently (no output at all) on HTTP errors (H)
     --fail-early    Fail and exit on first transfer error; can use with --fail

@jay jay added the documentation label Mar 31, 2017

@bagder

This comment has been minimized.

Show comment
Hide comment
@bagder

bagder Mar 31, 2017

Member

I'm 👍 on the main change, but I'm not too fond of the short help suggestion. I think that area is just too tight to make it make sense. "can use with --fail" doesn't really explain it.

Member

bagder commented Mar 31, 2017

I'm 👍 on the main change, but I'm not too fond of the short help suggestion. I think that area is just too tight to make it make sense. "can use with --fail" doesn't really explain it.

@jay jay closed this in 15b8c67 Mar 31, 2017

@jay jay deleted the jay:doc_improve_fail-early branch Mar 31, 2017

@jay

This comment has been minimized.

Show comment
Hide comment
@jay

jay Mar 31, 2017

Member

Ok, thanks for the review.

Member

jay commented Mar 31, 2017

Ok, thanks for the review.

@lock lock bot locked as resolved and limited conversation to collaborators May 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.