docs: Explain --fail-early does not imply --fail #1375
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in some scripts replacing --fail with --fail-early, not remembering the latter doesn't imply the former. You'd think I would know since it looks like I may have been one of the initial reviewers but I don't remember it.
For example I get a bunch of files using --fail-early --location --remote-name-all and they were all written even though one had failed. I think it's an easy mistake to make, and so it should be documented that it's for transfer errors and does not imply --fail but can be combined with it.
Not in this commit:
The short help could be modified as well, but it may be overkill?