Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: fix building with both sha256 and sha512 in unity mode #13751

Closed
wants to merge 1 commit into from

Conversation

pps83
Copy link
Contributor

@pps83 pps83 commented May 22, 2024

  • Ch and Maj are also defined in curl_sha512_256.c.
  • Avoid defining short defines like R, S

@vszakats
Copy link
Member

vszakats commented May 22, 2024

What do you think of also prefixing Ch and Maj in curl_sha512_256.c? Mainly for good measure/symmetry and to avoid bumping into this when adding a future hash.

@vszakats vszakats added the cmake label May 22, 2024
@vszakats vszakats changed the title Fix building with both sha256 and sha512 in unity mode cmake: fix building with both sha256 and sha512 in unity mode May 22, 2024
@pps83
Copy link
Contributor Author

pps83 commented May 22, 2024

What do you think of also prefixing Ch and Maj in curl_sha512_256.c? Mainly for good measure/symmetry and to avoid bumping into this when adding a future hash.

updated

lib/curl_sha512_256.c Outdated Show resolved Hide resolved
@pps83 pps83 force-pushed the master-IR branch 2 times, most recently from c951e91 to 4222711 Compare May 23, 2024 05:37
@jay jay closed this in 30c3bf1 May 24, 2024
@jay
Copy link
Member

jay commented May 24, 2024

Thanks

@pps83 pps83 deleted the master-IR branch May 25, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants