Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cf-socket: improve SO_SNDBUF update for Winsock #13827

Closed
wants to merge 1 commit into from

Conversation

jay
Copy link
Member

@jay jay commented May 29, 2024

  • Rename: Curl_sndbufset => Curl_sndbuf_init

  • Rename: win_update_buffer_size => win_update_sndbuf_size

  • Save the last set SO_SNDBUF size to compare against so that we can avoid setsockopt calls every second.

This is a follow-up to 0b520e1 which moved the SO_SNDBUF update check into cf-socket. This change improves it further by making the function names easier to understand and reducing the amount of setsockopt calls.

Closes #xxxx

- Rename: Curl_sndbufset => Curl_sndbuf_init

- Rename: win_update_buffer_size => win_update_sndbuf_size

- Save the last set SO_SNDBUF size to compare against so that we can
  avoid setsockopt calls every second.

This is a follow-up to 0b520e1 which moved the SO_SNDBUF update check
into cf-socket. This change improves it further by making the function
names easier to understand and reducing the amount of setsockopt calls.

Closes #xxxx
@jay jay closed this in acb9eff May 30, 2024
@jay jay deleted the modified__winsock-move-sendbuf-update branch May 30, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tidy-up Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

None yet

2 participants