Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Unify http3 workflows into one #13841

Closed
wants to merge 1 commit into from

Conversation

tatsuhiro-t
Copy link
Contributor

This commit unifies the following http3 workflows into http3-linux.yml:

  • ngtcp2-linux.yml
  • osslq-linux.yml
  • quiche-linux.yml

The idea is better use of the build cache. Previously, they independently create caches with the same key. Some of the caches include source code and intermediate object files, which makes cache quite large. In this commit, only built artifacts are cached, which drastically reduces the cache size. OpenSSL v3, mod_h2 and quiche caches still include all stuff, but they are left for the later improvement. Because the contents of the cache have been changed, the cache keys are also changed to include the word "http3".

This commit unifies the following http3 workflows into
http3-linux.yml:

- ngtcp2-linux.yml
- osslq-linux.yml
- quiche-linux.yml

The idea is better use of the build cache.  Previously, they
independently create caches with the same key.  Some of the caches
include source code and intermediate object files, which makes cache
quite large.  In this commit, only built artifacts are cached, which
drastically reduces the cache size.  OpenSSL v3, mod_h2 and quiche
caches still include all stuff, but they are left for the later
improvement.  Because the contents of the cache have been changed, the
cache keys are also changed to include the word "http3".
@github-actions github-actions bot added the CI Continuous Integration label May 31, 2024
@icing
Copy link
Contributor

icing commented May 31, 2024

cc @MAntoniak, in case you're interested.

@MAntoniak
Copy link
Contributor

cc @MAntoniak, in case you're interested.

Hmm, not really. I think you mean #13838 :)

@bagder bagder closed this in a817417 Jun 1, 2024
@bagder
Copy link
Member

bagder commented Jun 1, 2024

Thanks!

@tatsuhiro-t tatsuhiro-t deleted the gha-http3-cache branch June 3, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Continuous Integration
Development

Successfully merging this pull request may close these issues.

None yet

4 participants