Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: fix thread entry point to return DWORD on WinCE #13877

Closed
wants to merge 1 commit into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jun 4, 2024

We already do this in tests/server/util.c:

curl/tests/server/util.c

Lines 604 to 606 in 97e5e37

#ifdef _WIN32_WCE
static DWORD WINAPI main_window_loop(LPVOID lpParameter)
#else

and in sockfilt.c, lib3026.c.

Before this patch it returned unsigned int.

Closes #13877

@vszakats vszakats added the Windows Windows-specific label Jun 4, 2024
vszakats added a commit to vszakats/curl that referenced this pull request Jun 4, 2024
Headers says that the return value is `DWORD`. We already honor
this in `tests/server/util.c`:
https://github.com/curl/curl/blob/97e5e37cc8269660bc5d4a1936f10f2390b97c5a/tests/server/util.c#L604-L606

Do the same in the lib code.

Closes curl#13877
@vszakats vszakats changed the title lib: fix thread entry point return value to be long on WinCE lib: fix thread entry point to return DWORD on WinCE Jun 4, 2024
vszakats added a commit to vszakats/curl that referenced this pull request Jun 4, 2024
@vszakats vszakats closed this in 8338466 Jun 4, 2024
@vszakats vszakats deleted the wincefixup branch June 4, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Windows-specific
Development

Successfully merging this pull request may close these issues.

None yet

1 participant