Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: bring curl-config.cmake closer to FindCURL #13897

Closed
wants to merge 3 commits into from

Conversation

vszakats
Copy link
Member

@vszakats vszakats commented Jun 5, 2024

Set CURL_LIBRARIES and CURL_INCLUDE_DIRS variables
for compatibility with CMake's FindCURL.cmake:
https://github.com/Kitware/CMake/blob/b411d0146c2e06acfb0c823bb039e99f0191b611/Modules/FindCURL.cmake#L209

For dependent projects, CMake's suggestion is to replace
CURL_LIBRARIES with CURL::libcurl, and drop CURL_INCLUDE_DIRS.

Reported-by: Aurélien Pierre
Ref: https://curl.se/mail/lib-2024-06/0014.html
Ref: https://gitlab.kitware.com/cmake/cmake/-/issues/24580
Closes #13897


/cc @aurelienpierre Do you think this would help with this issue?

Ref: aurelienpierreeng/ansel#334

For compatibility with CMake's `FindCURL.cmake`.

Reported-by: Aurélien Pierre
Ref: https://curl.se/mail/lib-2024-06/0007.html
Closes #xxxxx
@vszakats vszakats added the cmake label Jun 5, 2024
@github-actions github-actions bot added the build label Jun 5, 2024
@vszakats

This comment was marked as duplicate.

@vszakats vszakats changed the title cmake: set CURL_LIBRARIES in curl-config.cmake cmake: bring curl-config.cmake closer to FindCURL Jun 7, 2024
@vszakats vszakats changed the title cmake: bring curl-config.cmake closer to FindCURL cmake: bring curl-config.cmake closer to FindCURL Jun 7, 2024
@vszakats vszakats closed this in 1dec702 Jun 13, 2024
@vszakats vszakats deleted the cmake-findcurl-compatibility branch June 13, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

1 participant